fix(instrumentation-redis-4): avoid shimmer warning by only wrapping multi/MULTI if they exist #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multi/MULTI if they exist
Codecov Report
@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 91.72% 91.69% -0.03%
==========================================
Files 139 139
Lines 7128 7130 +2
Branches 1433 1435 +2
==========================================
Hits 6538 6538
- Misses 590 592 +2
|
pichlermarc
added
bug
pichlermarc
approved these changes
Oct 12, 2023
plugins/node/opentelemetry-instrumentation-redis-4/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Pichler <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "no original function multi to wrap" warning from shimmer when wrapping recent versions of
@redis/client.Refs: #1708