Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baggage-log-record-processor): add package baggage log record processor #2754

Merged
merged 17 commits into from
Mar 28, 2025

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Mar 13, 2025

Creation of Baggage Log Record Processor. The approach is very similar to the existent BaggageSpanProcessor.
Creating this new package to align with other SDKs who also have this (e.g. Java and .NET)

This processor adds attributes to LogRecords that were in the baggage. All keys can be added or the user can filter by the ones they want.

@maryliag maryliag changed the title add tests for baggage log record processor feat(baggage-log-record-processor): add package baggage log record processor Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (407f615) to head (a9ead9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
+ Coverage   89.44%   89.46%   +0.01%     
==========================================
  Files         172      174       +2     
  Lines        8310     8324      +14     
  Branches     1591     1593       +2     
==========================================
+ Hits         7433     7447      +14     
  Misses        877      877              
Files with missing lines Coverage Δ
...cord-processor/src/baggage-log-record-processor.ts 100.00% <100.00%> (ø)
packages/baggage-log-record-processor/src/types.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag maryliag marked this pull request as ready for review March 13, 2025 19:06
@maryliag maryliag requested a review from a team as a code owner March 13, 2025 19:06
Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of quick suggestions. I'll give more feedback on a second review :)

@david-luna
Copy link
Contributor

CI failure is happening in mongodb tests. Theres is a PR to get rid of that #2764

{
"name": "@opentelemetry/baggage-log-record-processor",
"version": "0.0.1",
"description": "OpenTelemetry Baggage Log Record Processor for Node.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"for Node.js"? I know you are just copying from baggage-span-processor here. Is there anything Node.js-specific in this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I was just using the same definition. Let me update it to be more generic

@trentm trentm merged commit 03350ef into open-telemetry:main Mar 28, 2025
20 checks passed
@dyladan dyladan mentioned this pull request Mar 28, 2025
@maryliag maryliag deleted the baggage-log-processor branch March 28, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants