-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baggage-log-record-processor): add package baggage log record processor #2754
Conversation
…trib into baggage-log-processor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
+ Coverage 89.44% 89.46% +0.01%
==========================================
Files 172 174 +2
Lines 8310 8324 +14
Branches 1591 1593 +2
==========================================
+ Hits 7433 7447 +14
Misses 877 877
🚀 New features to boost your workflow:
|
…trib into baggage-log-processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of quick suggestions. I'll give more feedback on a second review :)
Co-authored-by: David Luna <[email protected]>
…trib into baggage-log-processor
CI failure is happening in |
…trib into baggage-log-processor
{ | ||
"name": "@opentelemetry/baggage-log-record-processor", | ||
"version": "0.0.1", | ||
"description": "OpenTelemetry Baggage Log Record Processor for Node.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"for Node.js"? I know you are just copying from baggage-span-processor here. Is there anything Node.js-specific in this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I was just using the same definition. Let me update it to be more generic
…trib into baggage-log-processor
Creation of Baggage Log Record Processor. The approach is very similar to the existent BaggageSpanProcessor.
Creating this new package to align with other SDKs who also have this (e.g. Java and .NET)
This processor adds attributes to LogRecords that were in the baggage. All keys can be added or the user can filter by the ones they want.