feat: Browser Navigation Instrumentation #3148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abinet18
changed the title
Abinet18
changed the title
Abinet18
changed the title
Abinet18
force-pushed
the
feat/instrumentation-navigation
branch
from
a1fbf7d to
9ef7a8a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
david-luna
reviewed
Oct 22, 2025
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
Abinet18
force-pushed
the
feat/instrumentation-navigation
branch
from
b4f4f99 to
42bfa43
Compare
overbalance
suggested changes
Oct 29, 2025
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
david-luna
reviewed
Nov 3, 2025
| */ | ||
| constructor(config: BrowserNavigationInstrumentationConfig) { | ||
| super(PACKAGE_NAME, PACKAGE_VERSION, config); | ||
| this.eventLogger = logs.getLogger(PACKAGE_NAME, PACKAGE_VERSION); |
There was a problem hiding this comment.
InstrumentationAbstract already provides a getter for the logger in https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation/src/instrumentation.ts#L96-L98
overbalance
suggested changes
Nov 3, 2025
Comment on lines
+46
to
+51
| // All true by default; override as needed | ||
| emitOnPageLoad: true, | ||
| emitOnHistoryChange: true, | ||
| emitOnPopState: true, | ||
| emitOnHashChange: true, | ||
| // useNavigationApiIfAvailable: false, |
There was a problem hiding this comment.
Looks like this is out-of-date.
| } from '@opentelemetry/sdk-logs'; | ||
| import { OTLPLogExporter } from '@opentelemetry/exporter-logs-otlp-http'; | ||
| import { registerInstrumentations } from '@opentelemetry/instrumentation'; | ||
| import { Resource } from '@opentelemetry/resources'; |
There was a problem hiding this comment.
This is example is using old core/resources. Should it be using ^2.0.0?
| import { OTLPLogExporter } from '@opentelemetry/exporter-logs-otlp-http'; | ||
| import { registerInstrumentations } from '@opentelemetry/instrumentation'; | ||
| import { Resource } from '@opentelemetry/resources'; | ||
| import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions'; |
There was a problem hiding this comment.
Same question here because this is deprecated.
| "@opentelemetry/exporter-logs-otlp-http": "^0.52.1", | ||
| "@opentelemetry/exporter-trace-otlp-http": "^0.39.1", | ||
| "@opentelemetry/instrumentation": "^0.39.1", | ||
| "@opentelemetry/instrumentation-document-load": "^0.32.2", |
There was a problem hiding this comment.
I would keep this explicitly imported.
|
@Abinet18 I forgot to mention that you should delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Creates a new instrumentation for browser navigation, in place of page view instrumentation that was being worked in this PR, with event defined in SemConv for this event
Short description of the changes