-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(instrumentation-http) Capture Synthetic Source Type on Requests #5488
base: main
Are you sure you want to change the base?
feat:(instrumentation-http) Capture Synthetic Source Type on Requests #5488
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5488 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 308 308
Lines 7927 7927
Branches 1604 1604
=======================================
Hits 7527 7527
Misses 400 400 🚀 New features to boost your workflow:
|
(Aside: Eww. I just had my first data loss with GitHub forms. I had a couple comments in pending review, then the PR was updated with new commits, then I hit the GitHub "refresh" link to update the PR diff and it lost my pending review comments.) |
experimental/packages/opentelemetry-instrumentation-http/src/internal-types.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Trent Mick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few notes 🙂
experimental/packages/opentelemetry-instrumentation-http/src/types.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-http/src/utils.ts
Outdated
Show resolved
Hide resolved
This PR looks good to me! |
Short description of the changes
Adds support for marking bot/test traffic as synthetic based on the
user-agent
header.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
user-agent
header are marked as synthetic.Checklist: