Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(instrumentation-http) Capture Synthetic Source Type on Requests #5488

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

JacksonWeber
Copy link
Contributor

Short description of the changes

Adds support for marking bot/test traffic as synthetic based on the user-agent header.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added test to ensure that requests that have the appropriate user-agent header are marked as synthetic.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@JacksonWeber JacksonWeber requested a review from a team as a code owner February 20, 2025 01:07
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (eaebf76) to head (cd2afd8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5488   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         308      308           
  Lines        7927     7927           
  Branches     1604     1604           
=======================================
  Hits         7527     7527           
  Misses        400      400           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm
Copy link
Contributor

trentm commented Feb 26, 2025

(Aside: Eww. I just had my first data loss with GitHub forms. I had a couple comments in pending review, then the PR was updated with new commits, then I hit the GitHub "refresh" link to update the PR diff and it lost my pending review comments.)

@JacksonWeber JacksonWeber requested a review from trentm February 26, 2025 23:22
@JacksonWeber JacksonWeber changed the title feat:(http-instrumentation) Capture Synthetic Source Type on Requests feat:(instrumentation-http) Capture Synthetic Source Type on Requests Feb 26, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few notes 🙂

@JacksonWeber JacksonWeber requested a review from pichlermarc March 5, 2025 18:37
@nsaiprakash90
Copy link

This PR looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants