Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add sdk-v1.x dist-tag when publishing from v1.x #5495

Draft
wants to merge 2 commits into
base: v1.x
Choose a base branch
from

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Feb 20, 2025

Which problem is this PR solving?

Important

This PR targets v1.x - keeping as draft until we're ready to release 2.x, until then releases from this branch should still target latest

To avoid having releases from v1.x end up with the latest tag automatically, this PR adds specific dist-tag to publishes from the v1.x branch.

The dist-tag chosen:

  • sdk-v1.x to show that the packages are compatible with v1.x
  • I did not put another ts4.4 tag as originally planned as lerna errors when using more than one tag.

@pichlermarc pichlermarc requested a review from a team as a code owner February 20, 2025 11:45
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.x@ac8641a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.x    #5495   +/-   ##
=======================================
  Coverage        ?   94.64%           
=======================================
  Files           ?      322           
  Lines           ?     8060           
  Branches        ?     1633           
=======================================
  Hits            ?     7628           
  Misses          ?      432           
  Partials        ?        0           

@pichlermarc pichlermarc changed the title ci: add dist tags on v1.x releases ci: add dist tags when publishing from v1.x Feb 20, 2025
@pichlermarc pichlermarc marked this pull request as draft February 20, 2025 14:20
@pichlermarc pichlermarc changed the title ci: add dist tags when publishing from v1.x ci: add sdk-v1.x dist-tag when publishing from v1.x Feb 20, 2025
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know still draft, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants