-
Notifications
You must be signed in to change notification settings - Fork 228
feat(collector/receiver): expose service.instance.id #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm not entirely sure this change is really adding something new. There is already a |
|
Upon closer inspection, it looks like this may only be supported in node.js and java |
|
So in my opinion, this feature is already solved in a different way. I believe otel already supports aws lambda resource detection for most languages, which should include the
@tylerbenson @serkan-ozal any opinion on this? |
|
In our use case the (Python) Lambda code itself is not instrumented with opentelemetry, but the opentelemetry-collector-lambda is running alongside the execution (as a Lambda extension). The logs that we receive lack the attribute you referenced above. This PR adds this ability to enrich the logs implemented at collector-side (so we don't have to instrument the Python code just to collect the logs that would otherwise be available through the Telemetry API anyways). |
|
I'll take a deeper look to the attributes using the debug exporter to see all metadata, I might have missed something |
|
What I am unable to see here is that who puts AWS CloudWatch log stream id into the |
|
Sorry for the delay, I caught up with other issues. To give you more information I managed to test this internally on a staging environment using a As you can see above, there's a Answering your question, the |
Description
The
service.instance.ididentifier is unique to a component (a Lambda execution), and it may have several advantages exposing this information:Testing
Tested live on a Lambda function, on top of #2011:
