Added protocol handling for ServicePort and fixed type/value naming inside generic receiver #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog pipeline failed, I will add an entry mentioning fix of the #2597 |
|
Working on lint... |
|
Changelog done, Lint done |
pavolloffay
reviewed
Feb 14, 2024
The name is not correctly split before it is checked. Split it first. Signed-off-by: Oldřich Jedlička <[email protected]>
The generic implementation does not allow to specify different endpoints and endpoint-specific protocols, so split the implementation instead of trying to make the generic implementation a complex catch-all-party. Signed-off-by: Oldřich Jedlička <[email protected]>
It is legal to have the same protocol number and different protocol, so handle it accordingly. Also interpret empty protocol as TCP, like the K8s does. Signed-off-by: Oldřich Jedlička <[email protected]>
Signed-off-by: Oldřich Jedlička <[email protected]>
|
Done. Anything more? |
|
I see that End-to-end tests e2e on K8s 1.29 test failed, but I cannot find anything specific to this Pull Request. |
|
maybe it was just flaky |
pavolloffay
approved these changes
Feb 14, 2024
jaronoff97
approved these changes
Feb 14, 2024
|
thank you for your contribution! |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…nside generic receiver (open-telemetry#2619) * Fix handling of type The name is not correctly split before it is checked. Split it first. Signed-off-by: Oldřich Jedlička <[email protected]> * Split parsing of Syslog, TCP Log and UDP Log parsers The generic implementation does not allow to specify different endpoints and endpoint-specific protocols, so split the implementation instead of trying to make the generic implementation a complex catch-all-party. Signed-off-by: Oldřich Jedlička <[email protected]> * Handle port numbers together with protocols It is legal to have the same protocol number and different protocol, so handle it accordingly. Also interpret empty protocol as TCP, like the K8s does. Signed-off-by: Oldřich Jedlička <[email protected]> * Changelog updates Signed-off-by: Oldřich Jedlička <[email protected]> --------- Signed-off-by: Oldřich Jedlička <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes three bugs:
Link to tracking Issue:
resolves: #2597
resolves: #767
Testing:
Added tests and also tested
udplogandtcplogin our deployment.Documentation:
This is purely a bugfix, so no documentation.