Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up signatures #2621

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

jaronoff97
Copy link
Contributor

Description:
This PR cleans up all the places that need to convert the v1alpha1 type to the v1alpha2 by minimizing the calls to the conversion function. Other than the type changes all over, the main thing that changed is the tests which previously built a whole params object, which really only needed to build a collector object.

Link to tracking Issue: closes #2592

Testing: unit testing

Documentation: N/A

@jaronoff97 jaronoff97 requested a review from a team February 12, 2024 21:46
@jaronoff97 jaronoff97 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 12, 2024
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some functions should be renamed but I'm fine approving this as-is.

@jaronoff97 jaronoff97 enabled auto-merge (squash) February 13, 2024 15:52
@jaronoff97 jaronoff97 merged commit 4d26028 into open-telemetry:main Feb 13, 2024
29 checks passed
@jaronoff97 jaronoff97 deleted the clean-up-signatures branch February 13, 2024 16:01
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* mostly working signatures

* Clean up types to only marshal once

* linting

* rename methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1alpha2: Minimise signatures of object generation functions
2 participants