Add v1alpha2 embedded Target Allocator struct #2623
Merged
+393
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add and use the embedded Target Allocator struct for v1alpha2. The changes mostly involve label selectors for Prometheus CR. Worth noting that this involves a change in semantics for said selectors, as an empty selector now selects nothing, which is in line with the standard, but different from v1alpha1.
swiatekm
commented
Feb 13, 2024
| @@ -31,5 +31,5 @@ const ( | |||
| TargetAllocatorAllocationStrategyConsistentHashing TargetAllocatorAllocationStrategy = "consistent-hashing" | |||
|
|
|||
| // TargetAllocatorFilterStrategyRelabelConfig targets will be consistently drops targets based on the relabel_config. | |||
| TargetAllocatorFilterStrategyRelabelConfig TargetAllocatorFilterStrategy = "consistent-hashing" | |||
| TargetAllocatorFilterStrategyRelabelConfig TargetAllocatorFilterStrategy = "relabel-config" | |||
There was a problem hiding this comment.
This is a small bug fix, the value was simply wrong.
3 tasks
jaronoff97
reviewed
Feb 13, 2024
jaronoff97
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
The semantics change is fine to me IMO, when we actually start using this in #2565 we should include this in a changelog maybe.
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Add and use the embedded Target Allocator struct for v1alpha2. The changes mostly involve label selectors for Prometheus CR. Worth noting that this involves a change in semantics for said selectors, as an empty selector now selects nothing, which is in line with the standard, but different from v1alpha1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and use the embedded Target Allocator struct for v1alpha2. The changes mostly involve label selectors for Prometheus CR.
Worth noting that this involves a change in semantics for said selectors, as an empty selector now selects nothing, which is in line with the standard, but different from v1alpha1.