Ensure unique names for ClusterRoles in e2e tests #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
test/e2e-clusterrole-names
branch
from
785dedd to
0b28930
Compare
pavolloffay
approved these changes
Feb 14, 2024
I think kuttl cleans them up. It has a |
swiatekm
force-pushed
the
test/e2e-clusterrole-names
branch
from
0b28930 to
ab9d437
Compare
jaronoff97
approved these changes
Feb 15, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterRoles with the same name in different tests can cause hard to debug test failures due to race conditions. With this fix, all ClusterRoles have unique names.