Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Fix instrumentation test asserts. #2702

Merged
merged 5 commits into from
Mar 12, 2024
Merged

[Chore] Fix instrumentation test asserts. #2702

merged 5 commits into from
Mar 12, 2024

Conversation

IshwarKanse
Copy link
Contributor

@IshwarKanse IshwarKanse commented Mar 4, 2024 •
edited
Loading

Description:

  • Fixes asserts for the instrumentation tests.
  • Checks for the status of containers in the application pod.
  • Uses catch: to collect all the container logs from failing instrumented application pod.
  • Unblock instrumentation-apache-multicontainer and instrumentation-nginx-multicontainer tests.

Testing:

@IshwarKanse IshwarKanse requested a review from a team March 4, 2024 10:12
@IshwarKanse IshwarKanse marked this pull request as draft March 4, 2024 10:12
@IshwarKanse IshwarKanse changed the title Fix instrumentation test asserts. [Chore] Fix instrumentation test asserts. Mar 4, 2024
@IshwarKanse IshwarKanse force-pushed the fix-inst branch 3 times, most recently from 0771546 to cf3feaf Compare March 4, 2024 13:47
@IshwarKanse IshwarKanse mentioned this pull request Mar 5, 2024
Merged
@IshwarKanse IshwarKanse marked this pull request as ready for review March 5, 2024 07:39
@IshwarKanse
Copy link
Contributor Author

@iblancasa @swiatekm-sumo Can you help to review and approve this PR. I'm working on the e2e-multi-instrumentation tests. Will create a new PR for it.

@IshwarKanse
Copy link
Contributor Author

For the unblocked tests which we were skipping previously. The tests didn't flake even after 5-10 runs.

pavolloffay
pavolloffay reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. could we remove some assertions from the nginx and httpd?

swiatekm
swiatekm approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IshwarKanse
Copy link
Contributor Author

@swiatekm-sumo @pavolloffay @iblancasa Thanks, This is the one for fixing multi instrumentation tests. #2709

@IshwarKanse IshwarKanse mentioned this pull request Mar 6, 2024
Closed
@IshwarKanse IshwarKanse mentioned this pull request Mar 7, 2024
Closed
@iblancasa
Copy link
Contributor

@swiatekm-sumo @pavolloffay is there anything pending from this PR?

@pavolloffay pavolloffay merged commit b95fa75 into open-telemetry:main Mar 12, 2024
31 checks passed
@IshwarKanse IshwarKanse deleted the fix-inst branch April 11, 2024 09:08
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@IshwarKanse
Fix instrumentation test asserts. (open-telemetry#2702)
8093b16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblancasa iblancasa iblancasa approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IshwarKanse @iblancasa @pavolloffay @swiatekm