Adding PodDNSConfig #2712
Closed
Adding PodDNSConfig #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <[email protected]>
|
@yuriolisa the PR needs to be rebased |
pavolloffay
reviewed
Mar 5, 2024
Signed-off-by: Yuri Sa <[email protected]>
iblancasa
reviewed
Mar 6, 2024
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
|
@yuriolisa can this PR wait until we release v1beta1? It'd make things simpler, and spare you from having to include this field in the conversion functions. |
|
Thanks for your work @yuriolisa! Can I make a last minute request? Could you as well add |
jaronoff97
reviewed
Apr 15, 2024
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
|
Closing this PR to open a fresh one without the API conversion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding PodDNSConfig
Link to tracking Issue(s):
Testing:
Added e2e tests to test the resolv.conf config.
Documentation: