Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more components to changelog template #2722

Merged

Conversation

pavolloffay
Copy link
Member

This aligns components with labels on the repo

@pavolloffay pavolloffay requested a review from a team March 6, 2024 16:21
@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 6, 2024
@@ -1,7 +1,7 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type:

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opapm, github action)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opapm, github action)
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp bridge, github action)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the label is just opamp, then I think it should be changed as well. WDYT @jaronoff97 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the label to opamp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, you have a typo there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, fixed

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay merged commit d918f06 into open-telemetry:main Mar 7, 2024
29 checks passed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Add more components to changelog template

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

---------

Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants