Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for prometheus selectors in conversion #2724

Merged
merged 1 commit into from
Mar 6, 2024
+59 −0
Merged

Add test for prometheus selectors in conversion #2724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions apis/v1alpha1/convert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,65 @@ func Test_tov1beta1AndBack(t *testing.T) {
assert.Equal(t, colalpha1, colalpha1Converted)
}

func Test_tov1beta1AndBack_prometheus_selectors(t *testing.T) {
t.Run("nil-selectors", func(t *testing.T) {
colalpha1 := OpenTelemetryCollector{
Spec: OpenTelemetryCollectorSpec{
TargetAllocator: OpenTelemetryTargetAllocator{
PrometheusCR: OpenTelemetryTargetAllocatorPrometheusCR{
// nil or empty map means select everything
PodMonitorSelector: nil,
ServiceMonitorSelector: nil,
},
},
},
}

colbeta1 := v1beta1.OpenTelemetryCollector{}
err := colalpha1.ConvertTo(&colbeta1)
require.NoError(t, err)

// nil LabelSelector means select nothing
// empty LabelSelector mean select everything
assert.NotNil(t, colbeta1.Spec.TargetAllocator.PrometheusCR.PodMonitorSelector)
assert.NotNil(t, colbeta1.Spec.TargetAllocator.PrometheusCR.ServiceMonitorSelector)
assert.Equal(t, 0, len(colalpha1.Spec.TargetAllocator.PrometheusCR.PodMonitorSelector))
assert.Equal(t, 0, len(colalpha1.Spec.TargetAllocator.PrometheusCR.ServiceMonitorSelector))

err = colalpha1.ConvertFrom(&colbeta1)
require.NoError(t, err)
assert.Nil(t, colalpha1.Spec.TargetAllocator.PrometheusCR.PodMonitorSelector)
assert.Nil(t, colalpha1.Spec.TargetAllocator.PrometheusCR.ServiceMonitorSelector)
})
t.Run("empty-selectors", func(t *testing.T) {
colalpha1 := OpenTelemetryCollector{
Spec: OpenTelemetryCollectorSpec{
TargetAllocator: OpenTelemetryTargetAllocator{
PrometheusCR: OpenTelemetryTargetAllocatorPrometheusCR{
// nil or empty map means select everything
PodMonitorSelector: map[string]string{},
ServiceMonitorSelector: map[string]string{},
},
},
},
}

colbeta1 := v1beta1.OpenTelemetryCollector{}
err := colalpha1.ConvertTo(&colbeta1)
require.NoError(t, err)

// nil LabelSelector means select nothing
// empty LabelSelector mean select everything
assert.NotNil(t, colbeta1.Spec.TargetAllocator.PrometheusCR.PodMonitorSelector)
assert.NotNil(t, colbeta1.Spec.TargetAllocator.PrometheusCR.ServiceMonitorSelector)

err = colalpha1.ConvertFrom(&colbeta1)
require.NoError(t, err)
assert.Equal(t, map[string]string{}, colalpha1.Spec.TargetAllocator.PrometheusCR.PodMonitorSelector)
assert.Equal(t, map[string]string{}, colalpha1.Spec.TargetAllocator.PrometheusCR.ServiceMonitorSelector)
})
}

func createTA() OpenTelemetryTargetAllocator {
replicas := int32(2)
runAsNonRoot := true
Expand Down
Loading