Remove unnecessary config marshalling wherever possible #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 2603-remove-unnecessary-config-marshalling
jaronoff97
commented
Mar 7, 2024
| @@ -131,57 +137,40 @@ func TestConfigToProbeShouldErrorIf(t *testing.T) { | |||
| service: | |||
| extensions: [health_check]`, | |||
| expectedErr: errNoExtensionHealthCheck, | |||
| }, { | |||
There was a problem hiding this comment.
some of these tests are no longer applicable!
pavolloffay
reviewed
Mar 8, 2024
| @@ -98,14 +98,56 @@ func (c Config) Yaml() (string, error) { | |||
| return buf.String(), nil | |||
| } | |||
|
|
|||
| // MetricsConfig comes from the collector | |||
| type MetricsConfig struct { | |||
There was a problem hiding this comment.
Could this be introduced in a separate PR?
| type Service struct { | ||
| Extensions *[]string `json:"extensions,omitempty" yaml:"extensions,omitempty"` | ||
| Extensions []string `json:"extensions,omitempty" yaml:"extensions,omitempty"` |
There was a problem hiding this comment.
IIRC this will enforce marshalling of empty array for extensions. Is this necessary?
| // +kubebuilder:pruning:PreserveUnknownFields | ||
| Telemetry *AnyConfig `json:"telemetry,omitempty" yaml:"telemetry,omitempty"` | ||
| // +kubebuilder:pruning:PreserveUnknownFields | ||
| Pipelines AnyConfig `json:"pipelines" yaml:"pipelines"` | ||
| } | ||
|
|
||
| // GetTelemetry serves as a helper function to access the fields we care about in the underlying telemetry struct. | ||
| // This exists to avoid needing to worry extra fields in the telemetry struct. | ||
| func (s *Service) GetTelemetry() *Telemetry { |
There was a problem hiding this comment.
could we add a test for this? Getting a telemetry from an existing yaml?
|
closing in favor of #2857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue(s):
Testing:
Documentation: