Python instrumentation featuregate to cli #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Mar 12, 2024
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: remove featuregate `EnablePythonAutoInstrumentationSupport`. Use command line flag `--enable-python-instrumentation` instead |
There was a problem hiding this comment.
What was the flag what we are removing?
There was a problem hiding this comment.
Should be operator.autoinstrumentation.python
TylerHelmuth
approved these changes
Mar 12, 2024
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: remove featuregate `EnablePythonAutoInstrumentationSupport`. Use command line flag `--enable-python-instrumentation` instead |
There was a problem hiding this comment.
Should be operator.autoinstrumentation.python
yuriolisa
reviewed
Mar 13, 2024
| @@ -136,6 +137,7 @@ func main() { | |||
| pflag.BoolVar(&enableMultiInstrumentation, "enable-multi-instrumentation", false, "Controls whether the operator supports multi instrumentation") | |||
| pflag.BoolVar(&enableApacheHttpdInstrumentation, constants.FlagApacheHttpd, true, "Controls whether the operator supports Apache HTTPD auto-instrumentation") | |||
| pflag.BoolVar(&enableDotNetInstrumentation, constants.FlagDotNet, true, "Controls whether the operator supports dotnet auto-instrumentation") | |||
| pflag.BoolVar(&enablePythonInstrumentation, constants.FlagPython, true, "Controls whether the operator supports python auto-instrumentation") | |||
There was a problem hiding this comment.
Should this instrumentation be disabled by default?
There was a problem hiding this comment.
It was a beta feature flag, and therefore enabled by default, so it should stay enabled imo.
There was a problem hiding this comment.
enabled by default sounds good
pavolloffay
approved these changes
Mar 13, 2024
swiatekm
approved these changes
Mar 13, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* remove python feature gate, use command-line instead * add chlog * fix python upgrade * fix typo at main * fix chlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
change python instrumentation into command line
Link to tracking Issue(s):
operator.autoinstrumentation.python#2672