Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] prepare release 0.97.0 #2767

Closed

Conversation

atsu85
Copy link
Contributor

@atsu85 atsu85 commented Mar 18, 2024

Description:

I followed RELEASE instructions

Link to tracking Issue(s):

Notes

@jaronoff97, based on the Release schedule it seems that you should be responsible for this release.

When trying to follow the release instructions I started questioning if i should even send the release PR myself, but I guess this PR shouldn't hurt.

I created separate commit for each step in the release instructions, so it might be easier to review my changes (i guess they will be squashed with the merge anyway)

Testing

I'm not completely sure if regarding the last point regarding preparing the release:

Check the OpenTelemetry Collector's changelog and ensure migration steps are present in pkg/collector/upgrade

there should have been any changes - I didn't add any myself, but I'm not sure if smth should have been added.

@atsu85 atsu85 requested a review from a team March 18, 2024 12:15
@atsu85 atsu85 changed the title prepare release 0.97.0 [chore] prepare release 0.97.0 Mar 18, 2024
@atsu85 atsu85 force-pushed the 2766-prepare-release-0.97.0 branch from 3878dd4 to feff453 Compare March 18, 2024 12:39
@jaronoff97
Copy link
Contributor

@atsu85 thanks for opening this! We need to wait on the collector release to merge and I'm not sure that will be this week given KubeCon EU is happening. Once the collectors release is complete I'd be happy to review and merge this!

@atsu85
Copy link
Contributor Author

atsu85 commented Mar 18, 2024

@jaronoff97 , thanks for quick reply.

We need to wait on the collector release to merge

Oh, I see I've bumped the collector version (that seems to be usually in sync with operator version) before it was released, and hence the e2e tests fail currently.

...and I'm not sure that will be this week

I'm wondering if it would be possible to release operator version without collector? I'm eager to start using it for lots of our projects.

If that would be an option, I guess i should revert most of my changes in version.txt , besides operator (probably should use patch version bump instead) and autoinstrumentation-nodejs?

@jaronoff97
Copy link
Contributor

@atsu85 i don't think we will be cutting a new release just for this, unfortunately. We usually reserve patch releases for immediate fixes in the most recent release. In the meantime, you should be able to provide your own auto-instrumentation node image by setting the auto-instrumentation-nodejs-image argument for the operator. The version you would like to use already has an image published.

@pavolloffay
Copy link
Member

Agree with @jaronoff97. We should wait for the collector release. In the meantime the nodejs image can be overridden in the instrumentation CR or you can override the base auto-instrumentation image as a flag on the operator.

@atsu85
Copy link
Contributor Author

atsu85 commented Mar 20, 2024

i don't think we will be cutting a new release just for this

yeah

In the meantime, you should be able to provide your own auto-instrumentation node image by setting the auto-instrumentation-nodejs-image argument for the operator

actually i already found that before i noticed your answer (and how to override it via opentelemetry-operator helm chart values)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release the operator v0.97.0
3 participants