Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add joblabel customization #2776

Closed
wants to merge 4 commits into from
Closed

Add joblabel customization #2776

wants to merge 4 commits into from

Conversation

jaronoff97
Copy link
Contributor

Description: Makes the job label customizable

Link to tracking Issue(s):

Testing: Unit and e2e

Documentation: api docs

@jaronoff97 jaronoff97 requested a review from a team March 21, 2024 17:11
swiatekm
swiatekm reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me, but I'm not sure we should be making it. See my comment under the issue.

@jaronoff97 jaronoff97 closed this Mar 23, 2024
@jaronoff97 jaronoff97 deleted the make-job-label-customizable branch March 23, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for custom job labels in the observability spec
2 participants
@jaronoff97 @swiatekm