Promote operator.collector.rewritetargetallocator feature flag to stable #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Mar 29, 2024
swiatekm
force-pushed
the
chore/promote-rewrite-featuregate
branch
from
cc6f713 to
c0e1e55
Compare
jaronoff97
approved these changes
Mar 29, 2024
|
@swiatekm-sumo Would you mind explaining why this PR is a breaking change for the user? Does it already influence people using the feature-gate or will it only when removing the feature gate in an upcoming release? |
Before this change, the feature flag was in Beta, and it was possible to disable it. After the change to Stable, this is no longer possible, and attempting to do so will cause an error. So this is a breaking change for users who had this flag explicitly disabled. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Promote the flag to stable, with the intent of removing it before the next release.
Link to tracking Issue(s): #2796
Testing:
Removed tests for the case where the flag is disabled.