-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add reconciliation for Collector v1beta1 CRD (#2703)" #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay is this okay to you?
@swiatekm-sumo the PR needs to be rebased |
pavolloffay
approved these changes
Apr 2, 2024
Done. |
pavolloffay
added a commit
to pavolloffay/opentelemetry-operator
that referenced
this pull request
Apr 5, 2024
…lemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc.
pavolloffay
added a commit
to pavolloffay/opentelemetry-operator
that referenced
this pull request
Apr 12, 2024
…lemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc.
pavolloffay
added a commit
that referenced
this pull request
Apr 12, 2024
#2813) * Revert "Revert" Add reconciliation for Collector v1beta1 CRD (#2703)" (#2800)" This reverts commit 57024fc. * Fix image Signed-off-by: Pavol Loffay <[email protected]> * Clarify hostport Signed-off-by: Pavol Loffay <[email protected]> * Fix issue after israel Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> --------- Signed-off-by: Pavol Loffay <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…2703)" (open-telemetry#2800) This reverts commit 9710eed
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…lemetry#2703)"… (open-telemetry#2813) * Revert "Revert" Add reconciliation for Collector v1beta1 CRD (open-telemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc. * Fix image Signed-off-by: Pavol Loffay <[email protected]> * Clarify hostport Signed-off-by: Pavol Loffay <[email protected]> * Fix issue after israel Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> --------- Signed-off-by: Pavol Loffay <[email protected]>
rubenvp8510
pushed a commit
to rubenvp8510/opentelemetry-operator
that referenced
this pull request
May 7, 2024
…lemetry#2703)"… (open-telemetry#2813) * Revert "Revert" Add reconciliation for Collector v1beta1 CRD (open-telemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc. * Fix image Signed-off-by: Pavol Loffay <[email protected]> * Clarify hostport Signed-off-by: Pavol Loffay <[email protected]> * Fix issue after israel Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> --------- Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9710eed
We want to push this back until we can include the Kubernetes distribution as the default image.