Only add to scheme when prometheus is available #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Apr 5, 2024
.chloggen/disable-looking-for-podmonitor-servicemonitor-when-not-needed.yaml
Outdated
Show resolved
Hide resolved
TylerHelmuth
approved these changes
Apr 5, 2024
jaronoff97
deleted the
disable-looking-for-podmonitor-servicemonitor-when-not-needed
branch
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Only add to scheme when prometheus is available * fix the bad stuff * logs and better changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Changes the prometheus operator integration to fail by logging (rather than panicking) and as a result only allowing the creation of prometheus resources when it is safe to do so.
Link to tracking Issue(s):
Testing: unit tests, e2e testing, local confirmation
Documentation: n/a