Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quiets some SUPER noisy logs #2812

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Quiets some SUPER noisy logs #2812

merged 1 commit into from
Apr 5, 2024

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Apr 4, 2024 •
edited
Loading

Description:
This PR puts more things into debug logs where they were providing no value to users. The logs and events for autoinstrumentation were particularly noisy – a user doesn't really care if we need to upgrade something that isn't enabled. We just end up crowding logs and events for autoinstrumentation with garbage:

{"level":"error","ts":"2024-04-04T19:45:02Z","logger":"instrumentation-upgrade","msg":"autoinstrumentation not enabled for this language","flag":"enable-nginx-instrumentation","stacktrace":"github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade.(*InstrumentationUpgrade).upgrade\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/pkg/instrumentation/upgrade/upgrade.go:147\ngithub.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade.(*InstrumentationUpgrade).ManagedInstances\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/pkg/instrumentation/upgrade/upgrade.go:102\nmain.addDependencies.func2\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/main.go:381\nsigs.k8s.io/controller-runtime/pkg/manager.RunnableFunc.Start\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/vendor/sigs.k8s.io/controller-runtime/pkg/manager/manager.go:301\nsigs.k8s.io/controller-runtime/pkg/manager.(*runnableGroup).reconcile.func1\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/vendor/sigs.k8s.io/controller-runtime/pkg/manager/runnable_group.go:223"}
{"level":"error","ts":"2024-04-04T19:45:02Z","logger":"instrumentation-upgrade","msg":"autoinstrumentation not enabled for this language","flag":"operator.autoinstrumentation.go","stacktrace":"github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade.(*InstrumentationUpgrade).upgrade\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/pkg/instrumentation/upgrade/upgrade.go:180\ngithub.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade.(*InstrumentationUpgrade).ManagedInstances\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/pkg/instrumentation/upgrade/upgrade.go:102\nmain.addDependencies.func2\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/main.go:381\nsigs.k8s.io/controller-runtime/pkg/manager.RunnableFunc.Start\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/vendor/sigs.k8s.io/controller-runtime/pkg/manager/manager.go:301\nsigs.k8s.io/controller-runtime/pkg/manager.(*runnableGroup).reconcile.func1\n\t/Users/jacob.aronoff/workspace/playground/opentelemetry-operator/vendor/sigs.k8s.io/controller-runtime/pkg/manager/runnable_group.go:223"}

Events:
  Type     Reason                          Age    From                    Message
  ----     ------                          ----   ----                    -------
  Warning  InstrumentationUpgradeRejected  56m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  56m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  50m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  50m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  42m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  42m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  30m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  30m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  26m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  26m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  21m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  21m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  18m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  18m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  13m    opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  13m    opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  8m47s  opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  8m47s  opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go
  Warning  InstrumentationUpgradeRejected  5m35s  opentelemetry-operator  support for is not enabled for enable-nginx-instrumentation
  Warning  InstrumentationUpgradeRejected  5m35s  opentelemetry-operator  support for is not enabled for operator.autoinstrumentation.go

Link to tracking Issue(s): n/a

Testing: logs

Documentation: n/a

@jaronoff97 jaronoff97 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 4, 2024
@jaronoff97 jaronoff97 requested a review from a team April 4, 2024 19:56
@pavolloffay pavolloffay merged commit 8fecea3 into open-telemetry:main Apr 5, 2024
31 checks passed
pavolloffay pushed a commit that referenced this pull request Apr 5, 2024
@swiatekm @jaronoff97
Clean up local workflow (#2774)
95586ff 
* bump to latest opamp (#2807)

* Release 0.97.0 (#2806)

* Release 0.97.0

* oops
''

* Quiets some SUPER noisy logs (#2812)

* Clean up local workflow

---------

Co-authored-by: Jacob Aronoff <[email protected]>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@jaronoff97
Quiets some SUPER noisy logs (open-telemetry#2812)
a1f850b
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@swiatekm @jaronoff97
Clean up local workflow (open-telemetry#2774)
6305ef1 
* bump to latest opamp (open-telemetry#2807)

* Release 0.97.0 (open-telemetry#2806)

* Release 0.97.0

* oops
''

* Quiets some SUPER noisy logs (open-telemetry#2812)

* Clean up local workflow

---------

Co-authored-by: Jacob Aronoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaronoff97 @pavolloffay