NodeJS instrumentation featuregates into cli #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
|
CI failed |
pavolloffay
approved these changes
Apr 26, 2024
TylerHelmuth
approved these changes
Apr 26, 2024
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
swiatekm
reviewed
Apr 29, 2024
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
|
Can you also delete the feature flag? LGTM otherwise. |
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
I've removed it. Could you please review it? |
TylerHelmuth
added
the
ready-to-merge
pavolloffay
approved these changes
Apr 30, 2024
8 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* NodeJS instrumentation featuregates into cli Signed-off-by: Yuri Sa <[email protected]> * Added complement to featuregate Signed-off-by: Yuri Sa <[email protected]> * Fixed Linters Signed-off-by: Yuri Sa <[email protected]> * Fixed Linters Signed-off-by: Yuri Sa <[email protected]> * Added e2e parameters Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Removed feature flags Signed-off-by: Yuri Sa <[email protected]> * Removed feature flags Signed-off-by: Yuri Sa <[email protected]> --------- Signed-off-by: Yuri Sa <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* NodeJS instrumentation featuregates into cli Signed-off-by: Yuri Sa <[email protected]> * Added complement to featuregate Signed-off-by: Yuri Sa <[email protected]> * Fixed Linters Signed-off-by: Yuri Sa <[email protected]> * Fixed Linters Signed-off-by: Yuri Sa <[email protected]> * Added e2e parameters Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Removed feature flags Signed-off-by: Yuri Sa <[email protected]> * Removed feature flags Signed-off-by: Yuri Sa <[email protected]> --------- Signed-off-by: Yuri Sa <[email protected]>
rubenvp8510
pushed a commit
to rubenvp8510/opentelemetry-operator
that referenced
this pull request
May 7, 2024
* NodeJS instrumentation featuregates into cli Signed-off-by: Yuri Sa <[email protected]> * Added complement to featuregate Signed-off-by: Yuri Sa <[email protected]> * Fixed Linters Signed-off-by: Yuri Sa <[email protected]> * Fixed Linters Signed-off-by: Yuri Sa <[email protected]> * Added e2e parameters Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Fixed e2e test Signed-off-by: Yuri Sa <[email protected]> * Removed feature flags Signed-off-by: Yuri Sa <[email protected]> * Removed feature flags Signed-off-by: Yuri Sa <[email protected]> --------- Signed-off-by: Yuri Sa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change NodeJS instrumentation feature gates into CLI flags
Link to tracking Issue(s):
operator.autoinstrumentation.nodejs#2674Testing:
Documentation: