-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce typed pipeline #2896
Merged
Merged
Introduce typed pipeline #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Apr 24, 2024
swiatekm
reviewed
Apr 30, 2024
swiatekm
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, with one question I'd like to answer before we merge.
swiatekm
approved these changes
Apr 30, 2024
pavolloffay
approved these changes
Apr 30, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* introduce more typing for pipelines * rock and a hard place * resolve tests * Fix tests * chlog * fix docs * thing * alphabet * remove chlog entry
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* introduce more typing for pipelines * rock and a hard place * resolve tests * Fix tests * chlog * fix docs * thing * alphabet * remove chlog entry
rubenvp8510
pushed a commit
to rubenvp8510/opentelemetry-operator
that referenced
this pull request
May 7, 2024
* introduce more typing for pipelines * rock and a hard place * resolve tests * Fix tests * chlog * fix docs * thing * alphabet * remove chlog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Introduces a typed pipeline for the collector. This allows us to really easily construct a list of enabled components.
NOTE! One decision we need to make:
By using a struct like this, we have to figure out how to handle an empty list of processors. I chose to always include it on marshal i.e. if someone has a pipeline configuration like this:
we will then unmarshal and remarshal it to be:
IMO this is fine and better than the reverse where we set it explicitly to an empty list and then don't remarshal it with that empty list. If someone has a way to make this work both ways, let me know :)
DECISION
From the SIG we decided this is fine, it's only visible to a user in their configmap, but no functionality difference.
Link to tracking Issue(s):
part of #2603
Testing: unit testing
Documentation: n/a