Fix pdb defaulting logic #3200
Merged
Fix pdb defaulting logic #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Aug 6, 2024
| type test struct { | ||
| name string | ||
| MinAvailable *intstr.IntOrString | ||
| type expected struct { |
There was a problem hiding this comment.
i swapped around where the defaulting is happening so now we should test that here.
iblancasa
approved these changes
Aug 7, 2024
pavolloffay
reviewed
Aug 7, 2024
pavolloffay
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a bug where we setting the field on the CRD itself which was causing it to be added permanently to the CR in the defaulting webhook. This meant that when a user went to apply a change and didn't want that default anymore we would crash.
Link to tracking Issue(s):
Testing: Unit tests, e2e tests, manual
Documentation: