[Chore] Test multi-container multi-instrumentation for ApacheHTTPD, Golang, SDK #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshwarKanse
force-pushed
the
fixinstrumenationtests
branch
from
21c564e to
5ad42c2
Compare
IshwarKanse
force-pushed
the
fixinstrumenationtests
branch
from
9677625 to
5ca97fa
Compare
jaronoff97
approved these changes
Oct 1, 2024
jaronoff97
reviewed
Oct 1, 2024
There was a problem hiding this comment.
why are we removing the 02 parts here?
There was a problem hiding this comment.
The files were not used in the tests. The resources and assertions were intended to verify that enabling the multi-container multi-instrumentation feature gate would disable the container names annotation (instrumentation.opentelemetry.io/container-names: ""). Recently, we added support for both annotation methods: language-specific instrumentation and container names annotations. #3213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Test multi-container multi-instrumenation for ApacheHTTPD, Golang, SDK
For Nginx , running into https://issues.redhat.com/browse/TRACING-4820 Will check if its a config issue or a bug.