Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api.md #3461

Closed
wants to merge 1 commit into from
Closed

Update api.md #3461

wants to merge 1 commit into from

Conversation

dominicqi
Copy link
Contributor

Reference Prometheus operator Api spec, the pod/service monitorSelector nil will matches no objects.

Description:
Fix api.md, PrometheusCR.ServiceMonitorSelector PodMonitorSelector nil will matches no objects

Prometheus CR Document

Reference Prometheus operator Api spec, the pod/service monitorSelector nil will matches no objects.
@dominicqi dominicqi requested a review from a team as a code owner November 15, 2024 03:16
Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to do that change in the apis/v1alpha1/opentelemetrycollector_types.go file

@dominicqi dominicqi closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants