Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allocation_fallback_strategy option as fallback strategy for per-node strategy #3482

Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
12e1282
Add least-weighted as fallback strategy for per-node strategy
lhp-nemlig Nov 21, 2024
b7649be
Add changelog file
lhp-nemlig Nov 21, 2024
31982b7
Change fallback strategy to consistent-hashing
lhp-nemlig Nov 21, 2024
92d0069
Update changelog
lhp-nemlig Nov 21, 2024
381222c
Fix bad test condition that might pass even if target was not assigned
lhp-nemlig Nov 21, 2024
ee6e856
Make fallback strategy a config option
lhp-nemlig Nov 21, 2024
ef2d720
Update changelog
lhp-nemlig Nov 21, 2024
ea6e956
Merge branch 'main' into add_fallback_strategy_for_per_node_strategy
lhp-nemlig Nov 21, 2024
6f757c3
Add period to test comments
lhp-nemlig Nov 21, 2024
e62f7d2
Merge branch 'main' into add_fallback_strategy_for_per_node_strategy
lhp-nemlig Nov 22, 2024
7711a32
Add feature gate for enabling fallback strategy
lhp-nemlig Nov 22, 2024
e1207cd
Fix featuregate id
lhp-nemlig Nov 22, 2024
7eabd10
Update cmd/otel-allocator/allocation/per_node_test.go
lhp-nemlig Nov 22, 2024
6be618c
Update cmd/otel-allocator/allocation/per_node_test.go
lhp-nemlig Nov 22, 2024
7d32f7e
Update cmd/otel-allocator/allocation/per_node_test.go
lhp-nemlig Nov 22, 2024
0254654
Only add fallbackstrategy if nonempty
lhp-nemlig Nov 22, 2024
a5b8dca
Remove unnecessary comments
lhp-nemlig Nov 22, 2024
d6435e3
Add unit test for fallbackstrategy feature gate
lhp-nemlig Nov 22, 2024
0f878f0
Update changelog
lhp-nemlig Nov 22, 2024
bf5a367
Merge branch 'main' into add_fallback_strategy_for_per_node_strategy
lhp-nemlig Nov 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bad test condition that might pass even if target was not assigned
lhp-nemlig committed Nov 21, 2024
commit 381222cb292e5474d6ec18ce7d19cf3015ac0358
2 changes: 1 addition & 1 deletion cmd/otel-allocator/allocation/per_node_test.go
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ func TestAllocationPerNode(t *testing.T) {
// one of the others, depending on the strategy and collector loop order
if targetHash == thirdTarget.Hash() {
assert.Empty(t, item.GetNodeName())
assert.LessOrEqual(t, len(itemsForCollector), 2)
assert.NotZero(t, len(itemsForCollector))
continue
}