Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label mapping for service.instance.id #3497

Merged
merged 14 commits into from
Dec 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .chloggen/service-instanc-id-mapping.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,23 @@ change_type: bug_fix
component: auto-instrumentation

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove the mapping of `app.kubernetes.io/instance` to `service.instance.id`, because multiple containers
should never share the same `service.instance.id`
note: Remove the mapping of `app.kubernetes.io/instance` to `service.instance.id`

# One or more tracking issues related to the change
issues: [3495]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
subtext: |
Technically, this is a breaking change, but we regard it as a bug fix because the previous behavior was incorrect.

In you did have multiple containers and use `app.kubernetes.io/instance` to set the `service.instance.id`,
you will now see multiple instances in the UI - which is the correct behavior.

You can still use the attribute `resource.opentelemetry.io/service.instance.id` to set the `service.instance.id`,
which will be shared across all containers in the pod - but this is not recommended.

Refer to the [semantic conventions](https://opentelemetry.io/docs/specs/semconv/resource/#service-experimental)
for more information.

Loading