Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky controller test for versioned ConfigMaps #3564

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

swiatekm
Copy link
Contributor

#3560 wasn't enough. I reverted those changes, as they didn't really help and just made the code more complex for no benefit.

Kubernetes creation timestamps only have a seconds-level precision. The ConfigMap versioning feature for collectors deleted the oldest ConfigMaps. For the test to work correctly, we need to wait at least 1 second between CR changes.

Kubernetes creation timestamps only have a seconds-level precision.
The ConfigMap versioning feature for collectors deleted the oldest
ConfigMaps. For the test to work correctly, we need to wait at least 1
second between CR changes.
@swiatekm swiatekm requested a review from a team as a code owner December 20, 2024 15:54
Comment on lines +861 to +863
OpenTelemetryCommonFields: v1beta1.OpenTelemetryCommonFields{
PodDisruptionBudget: &v1beta1.PodDisruptionBudgetSpec{},
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to avoid logs about the default being set. We should really get rid of that log line imo.

@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 20, 2024
@jaronoff97 jaronoff97 merged commit c399686 into open-telemetry:main Dec 20, 2024
38 of 39 checks passed
@swiatekm swiatekm deleted the test/fix-flaky-test branch December 20, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants