Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update tool github.com/golangci/golangci-lint/cmd/golangci-lint to v1.63.2 #3587

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 1, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/golangci/golangci-lint/cmd/golangci-lint v1.62.2 -> v1.63.2 age adoption passing confidence

Release Notes

golangci/golangci-lint (github.com/golangci/golangci-lint/cmd/golangci-lint)

v1.63.2

Compare Source

v1.63.1

Compare Source

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

v1.63.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 1, 2025
@renovate renovate bot requested a review from a team as a code owner January 1, 2025 16:58
@renovate renovate bot changed the title chore(deps): update tool github.com/golangci/golangci-lint/cmd/golangci-lint to v1.63.0 chore(deps): update tool github.com/golangci/golangci-lint/cmd/golangci-lint to v1.63.1 Jan 2, 2025
@renovate renovate bot force-pushed the renovate/github.com-golangci-golangci-lint-cmd-golangci-lint-1.x branch from 53a2bce to 0a11c25 Compare January 2, 2025 01:57
@swiatekm
Copy link
Contributor

swiatekm commented Jan 2, 2025

There's a panic in the Go parser, which probably means we need to upgrade Go itself first:

level=error msg="[runner] Panic stack trace: goroutine 1 [running]:\nruntime/debug.Stack()\n\t/opt/hostedtoolcache/go/1.22.10/x64/src/runtime/debug/stack.go:24 +0x5e\ngithub.com/golangci/golangci-lint/pkg/lint.(*Runner).runLinterSafe.func1()\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/lint/runner.go:152 +0x279\npanic({0x1890bc0?, 0xc0451e47d0?})\n\t/opt/hostedtoolcache/go/1.22.10/x64/src/runtime/panic.go:770 +0x132\ngo/token.(*File).Offset(0xc08c13ba40, 0xc000058d50?)\n\t/opt/hostedtoolcache/go/1.22.10/x64/src/go/token/position.go:279 +0xdc\ngithub.com/golangci/golangci-lint/pkg/goanalysis.buildIssues({0xc0dddb7808, 0x8, 0xc004540ee0?}, 0xc0000591a0)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runners.go:120 +0x9d6\ngithub.com/golangci/golangci-lint/pkg/goanalysis.runAnalyzers.func2()\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runners.go:69 +0x2db\ngithub.com/golangci/golangci-lint/pkg/goanalysis.runAnalyzers({0x1ddcbb0, 0xc0009cc080}, 0xc000098660)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/runners.go:79 +0x76a\ngithub.com/golangci/golangci-lint/pkg/goanalysis.MetaLinter.Run({{0xc0007f0600, 0x11, 0x20}, 0xc000def3b0}, {0x59588?, 0xc00264df80?}, 0xc000098660)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/goanalysis/metalinter.go:31 +0x145\ngithub.com/golangci/golangci-lint/pkg/lint.(*Runner).runLinterSafe(0x7fc69c334b78?, {0x1dd6698?, 0xc00070afc0?}, 0xc000098660, 0xc000768980)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/lint/runner.go:157 +0xb5\ngithub.com/golangci/golangci-lint/pkg/lint.(*Runner).Run.func1()\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/lint/runner.go:125 +0x27\ngithub.com/golangci/golangci-lint/pkg/timeutils.TrackStage[...].func1()\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:134 +0x2b\ngithub.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0026e6aa0, {0x1b6c40e, 0x15}, 0xc000059720)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:111 +0x44\ngithub.com/golangci/golangci-lint/pkg/timeutils.TrackStage[...](0x6?, {0x1b6c40e?, 0x0?}, 0x1ddf000?)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:133 +0x7e\ngithub.com/golangci/golangci-lint/pkg/lint.(*Runner).Run(0xc002c96030, {0x1dd6698, 0xc00070afc0}, {0xc000f8f2f0, 0x1, 0x29ff6c0?})\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/lint/runner.go:124 +0x2bc\ngithub.com/golangci/golangci-lint/pkg/commands.(*runCommand).runAnalysis(0xc00052e7e0, {0x1dd6698, 0xc00070afc0}, {0x29ff6c0, 0x0, 0x0})\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/commands/run.go:398 +0x1f1\ngithub.com/golangci/golangci-lint/pkg/commands.(*runCommand).runAndPrint(0xc00052e7e0, {0x1dd6698, 0xc00070afc0}, {0x29ff6c0, 0x0, 0x0})\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/commands/run.go:355 +0x285\ngithub.com/golangci/golangci-lint/pkg/commands.(*runCommand).execute(0xc00052e7e0, 0xc0006bba90?, {0x29ff6c0, 0x0, 0x0})\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/commands/run.go:261 +0x228\ngithub.com/spf13/cobra.(*Command).execute(0xc0004b6908, {0x29ff6c0, 0x0, 0x0})\n\t/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:989 +0xab1\ngithub.com/spf13/cobra.(*Command).ExecuteC(0xc0004b6308)\n\t/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1117 +0x3ff\ngithub.com/spf13/cobra.(*Command).Execute(...)\n\t/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1041\ngithub.com/golangci/golangci-lint/pkg/commands.(*rootCommand).Execute(0xc00086f320)\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/commands/root.go:83 +0x3d\ngithub.com/golangci/golangci-lint/pkg/commands.Execute({{0x1dbf130, 0x9}, {0x1e4aa0f, 0x7}, {0xc000f90f60, 0x52}, {0x1ae8f83, 0x9}})\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/pkg/commands/root.go:17 +0x5a\nmain.main()\n\t/home/runner/go/pkg/mod/github.com/golangci/[email protected]/cmd/golangci-lint/main.go:25 +0xc5\n"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: panic occurred: invalid Pos value 594624769 (should be in [594623636, 594624768])"

@renovate renovate bot changed the title chore(deps): update tool github.com/golangci/golangci-lint/cmd/golangci-lint to v1.63.1 chore(deps): update tool github.com/golangci/golangci-lint/cmd/golangci-lint to v1.63.2 Jan 2, 2025
@renovate renovate bot force-pushed the renovate/github.com-golangci-golangci-lint-cmd-golangci-lint-1.x branch from 0a11c25 to e410581 Compare January 2, 2025 13:28
We've had some OOM kills on Github Actions runners, hopefully this helps.
goheader in golanci-lint v1.63.2 incorrectly flags these files as having
invalid headers. Root cause not yet known.
@swiatekm swiatekm force-pushed the renovate/github.com-golangci-golangci-lint-cmd-golangci-lint-1.x branch from 1567659 to ef140d7 Compare January 2, 2025 15:24
@swiatekm swiatekm enabled auto-merge (squash) January 2, 2025 15:34
@swiatekm swiatekm merged commit c414b4d into main Jan 2, 2025
38 checks passed
@swiatekm swiatekm deleted the renovate/github.com-golangci-golangci-lint-cmd-golangci-lint-1.x branch January 2, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants