Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use client-go/kubernetes/scheme instead of kubectl/pkg/scheme #3596

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Jan 8, 2025

Description:

Use k8s/client-go/kubernetes/scheme instead of k8s/kubectl/pkg/scheme to avoid extra dependency.

@zchee zchee requested a review from a team as a code owner January 8, 2025 20:35
@zchee zchee force-pushed the avoid-kubectl-scheme branch from 0acd10b to f875864 Compare January 8, 2025 22:18
@zchee zchee force-pushed the avoid-kubectl-scheme branch from f875864 to 3ee2892 Compare January 8, 2025 22:19
@zchee zchee changed the title fix(deps): use runtime.NewScheme directly instead of kubectl/pkg/scheme fix(deps): use client-go/kubernetes/scheme instead of kubectl/pkg/scheme Jan 8, 2025
@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 9, 2025
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@swiatekm swiatekm enabled auto-merge (squash) January 9, 2025 11:29
@swiatekm swiatekm merged commit 51f6888 into open-telemetry:main Jan 9, 2025
38 of 39 checks passed
@zchee zchee deleted the avoid-kubectl-scheme branch January 9, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants