Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] do not initialize empty slices #3626

Merged
merged 1 commit into from
Jan 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/otel-allocator/allocation/allocator.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func (a *allocator) handleTargets(diff diff.Changes[*target.Item]) {
}

// Check for additions
assignmentErrors := []error{}
var assignmentErrors []error
for k, item := range diff.Additions() {
// Do nothing if the item is already there
if _, ok := a.targetItems[k]; ok {
Expand Down Expand Up @@ -297,7 +297,7 @@ func (a *allocator) handleCollectors(diff diff.Changes[*Collector]) {
a.strategy.SetCollectors(a.collectors)

// Re-Allocate all targets
assignmentErrors := []error{}
var assignmentErrors []error
for _, item := range a.targetItems {
err := a.addTargetToTargetItems(item)
if err != nil {
Expand Down
Loading