Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoinstrumentation] remove dependency on busybox, use native cp #3682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 30, 2025

Description:
Move away from busybox, use a native cp command.

Link to tracking Issue(s):
Fixes #1600

@atoulme atoulme requested a review from a team as a code owner January 30, 2025 07:47
@atoulme atoulme force-pushed the native_cp branch 3 times, most recently from 985da7c to 574778d Compare January 30, 2025 08:12
@atoulme
Copy link
Contributor Author

atoulme commented Jan 30, 2025

This PR requires to create images for cp:

  • ghcr.io/open-telemetry/opentelemetry-operator/cp_linux_amd64
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_linux_arm64
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_linux_ppc64le
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_linux_s390x
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_windows_amd64
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_windows_arm64
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_linux_amd64_fips
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_linux_arm64_fips
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_windows_amd64_fips
  • ghcr.io/open-telemetry/opentelemetry-operator/cp_windows_arm64_fips
  • ghcr.io/open-telemetry/opentelemetry-operator/cp

@swiatekm swiatekm added the discuss-at-sig This issue or PR should be discussed at the next SIG meeting label Feb 11, 2025
@swiatekm
Copy link
Contributor

I like the effort to do this, but this is a large enough change that it merits some discussion during our SIG meeting before we move on to implementation. Questions that we need to answer first:

  • Do we need a new publishable artifact to do this?
  • If so, how will we version it?
  • Do we support other projects using it?

Separately, for your specific implementation in this PR @atoulme :

  • At minimum, you need to support the -r flag, as the nodejs instrumentation uses it.
  • You have some unnecessary platforms there, we don't support Windows right now.
  • The FIPS stuff should go in a separate issue

@swiatekm swiatekm removed the discuss-at-sig This issue or PR should be discussed at the next SIG meeting label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BusyBox Licensing
2 participants