Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urllib3 upper limit to Python auto-instrumentation #3713

Merged

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Feb 13, 2025

Description:

Adds an upper version limit to urllib3 for Python auto-instrumentation. Python OTLP HTTP exporter depends on requests ~= 2.7 and that depends on "urllib3>=1.21.1,<3". urllib 2.3.0 is the latest and drops support of Python 3.8. We are still supporting Python 3.8.

Link to tracking Issue(s):

Testing: docker build finishes without error.

Documentation:

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review February 13, 2025 22:59
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner February 13, 2025 22:59
@tammy-baylis-swi
Copy link
Contributor Author

cc'ing @open-telemetry/python-approvers

@tammy-baylis-swi
Copy link
Contributor Author

I don't know if the unit test fails are related:

--- FAIL: TestOpenTelemetryCollectorReconciler_Reconcile (15.03s)

    --- FAIL: TestOpenTelemetryCollectorReconciler_Reconcile/stateful_should_update_collector_with_TA (1.82s)

--- FAIL: TestOpenTelemetryCollectorReconciler_Finalizer (1.24s)

FAIL	github.com/open-telemetry/opentelemetry-operator/controllers	31.734s

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I did a re-run.

@swiatekm
Copy link
Contributor

@tammy-baylis-swi could you resolve conflicts?

@tammy-baylis-swi
Copy link
Contributor Author

@tammy-baylis-swi could you resolve conflicts?

Addressed in d1798d5.

@swiatekm swiatekm merged commit 1a83da1 into open-telemetry:main Feb 15, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup errors with autoinstrumentation-python 0.50b
5 participants