Recommeded resource attributes #3797
Conversation
swiatekm
added
the
discuss-at-sig
zeitlinger
force-pushed
the
recommedded-resource-attributes
branch
from
5103776 to
b41b9da
Compare
iblancasa
removed
the
discuss-at-sig
There was a problem hiding this comment.
We discussed about this PR during the SIG call. Some comments:
- Could you add a feature gate to avoid the breaking change right now and give some time to users to upgrade?
- Are the semantic convention changes already released?
- Is there something we can do to avoid the breaking change?
| component: auto-instrumentation | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Update recommended resource attributes to match the [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/k8s-attributes.md) |
There was a problem hiding this comment.
Please add more info about the exact changes that need to be done for the operator.
Also, provide some kind of recommendation regarding upgrading.
There was a problem hiding this comment.
the subtext has all changes - is that sufficient?
The subtext should also cover what you need to consider for upgrading.
yes, we could - but I'm not sure if that's really warranted in this case:
See Having said that, I'm happy to add a flag if we decide to do so
we could add a different flag for the well-known attributes and deprecate the old flag |
|
@iblancasa please check again |
Description:
Updates the recommended resource attributes to comply with the semantic conventions.
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/k8s-attributes.md
Technically, it's a breaking change - looking for feedback if it's OK to change as is.
Link to tracking Issue(s):
Testing:
Adapted existing tests.
Documentation:
Adapted existing docs.