Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove unused defaultAutoDetectFrequency variable #3803

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

JaredTan95
Copy link
Member

Description:

Link to tracking Issue(s):

  • Resolves: #issue-number

Testing:

Documentation:

@JaredTan95 JaredTan95 requested a review from a team as a code owner March 13, 2025 13:55
@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 13, 2025
@swiatekm
Copy link
Contributor

@JaredTan95 could you fix the lint failure?

On a related note, I do not understand why the unused linter doesn't flag this. @open-telemetry/operator-approvers does anyone have an idea?

@iblancasa
Copy link
Contributor

@JaredTan95 could you fix the lint failure?

On a related note, I do not understand why the unused linter doesn't flag this. @open-telemetry/operator-approvers does anyone have an idea?

Because it doesn't check global unexported variables. We might want to enable deadcode.

@swiatekm
Copy link
Contributor

Because it doesn't check global unexported variables. We might want to enable deadcode.

deadcode was deprecated some time ago and is not present in latest golangci-lint. Which does actually find unused constants, but not if they're grouped. I'll see if there's a bug report about that.

@swiatekm swiatekm merged commit d7291dd into open-telemetry:main Mar 14, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants