Comment out autoinstrumentation-php in versions.txt #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SergeyKleyman would you see any issues with this? I don't want to break anything you might know about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PHP was recently added to versions.txt, which is great for progressing towards expanding language support. However, I’d like to keep versions.txt focused on features that are currently available in the operator.
Our downstream project relies on versions.txt for CI/CD, ensuring that only functional and accessible Docker images are referenced. Since PHP support isn’t ready yet, this is causing CI/CD failures due to the lack of a defined PHP image and the operator not having support for PHP implemented.
To avoid breaking CI/CD, this PR comments out the PHP version until official support is available.