Add IBM Instana Context Propagator#365
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
============================================
- Coverage 82.17% 81.72% -0.46%
+ Complexity 1870 1745 -125
============================================
Files 137 134 -3
Lines 7822 7322 -500
============================================
- Hits 6428 5984 -444
+ Misses 1394 1338 -56 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@bobstrecansky , Thank you for triggering the CI for this PR. However, the CI did not run for my project because I forgot to include the project in the GitHub workflow. Could you please retrigger the CI actions? Additionally, I’ve noticed that some unrelated projects, such as Instrumentation/Psr15, Instrumentation/Psr16, and others, are failing their CI checks. Since these are not dependent on this PR, could you advise on how such failures should be handled? |
You can ignore the unrelated failures here. 👍 |
|
I am not able to see these CI issues with local execution , However CI reports it . |
Co-authored-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
|
Hmm. I wonder why make all didn’t catch those errors. Obviously missed something with psalm override attribute too for psalm. |
|
Many thanks @brettmc for approving the PR. I see that CI checks for the Instana in successful for all supported PHP versions ? Is this PR good to merge ? |
ChrisLightfootWild
left a comment
ChrisLightfootWild
left a comment
There was a problem hiding this comment.
Left some final formatting bits I spotted, but that can always be done in your follow-up PR.
| } | ||
| Registry::registerTextMapPropagator( |
There was a problem hiding this comment.
| } | |
| Registry::registerTextMapPropagator( | |
| } | |
| Registry::registerTextMapPropagator( |
| } | ||
|
|
||
| if ($spanId && strlen($spanId) < 16) { | ||
| $spanId = str_pad($spanId, 16, '0', STR_PAD_LEFT); |
There was a problem hiding this comment.
| $spanId = str_pad($spanId, 16, '0', STR_PAD_LEFT); | |
| $spanId = str_pad($spanId, 16, '0', STR_PAD_LEFT); |
There was a problem hiding this comment.
This Will be addressed in the followup PR.
#370
| return (new NonRecordingSpan($spanContext)) | ||
| ->storeInContext($context); | ||
|
|
||
| } elseif (!$spanContext->isValid()) { |
There was a problem hiding this comment.
| return (new NonRecordingSpan($spanContext)) | |
| ->storeInContext($context); | |
| } elseif (!$spanContext->isValid()) { | |
| return (new NonRecordingSpan($spanContext)) | |
| ->storeInContext($context); | |
| } elseif (!$spanContext->isValid()) { |
There was a problem hiding this comment.
This Will be addressed in the followup PR.
#370
|
@brettmc @ChrisLightfootWild , where this Instana propagation package will be hosted on packagist.org. Thanks! |
4 participants
Which problem is this PR solving?
This PR adds a vendor specific propagator for the vendor specific trace correlation headers used by Instana.
Short description of the changes
Add Instana propagator plus unit tests.