fix Pre Hook Exception in case _controller is not stringable#366
Merged
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Nevay
reviewed
May 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=========================================
Coverage 83.45% 83.46%
- Complexity 1957 1958 +1
=========================================
Files 143 143
Lines 8190 8193 +3
=========================================
+ Hits 6835 6838 +3
Misses 1355 1355 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
trigrab
force-pushed
the
fix-pre-hook-exception
branch
2 times, most recently
from
d9eeb36 to
6e1f5d6
Compare
trigrab
force-pushed
the
fix-pre-hook-exception
branch
from
6e1f5d6 to
dfb2582
Compare
…pes integation test
trigrab
force-pushed
the
fix-pre-hook-exception
branch
from
dfb2582 to
a8c7f8e
Compare
brettmc
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes open-telemetry/opentelemetry-php#1569