fix: exception recording for Symfony sub-requests in instrumentation#494
Conversation
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>
|
|
|
@bobstrecansky could you take a look a this issue/PR? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
============================================
- Coverage 83.46% 83.44% -0.02%
Complexity 2330 2330
============================================
Files 149 149
Lines 8791 8791
============================================
- Hits 7337 7336 -1
- Misses 1454 1455 +1 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
LGTM, @Apoorva64 - can you write or update a test to show it working? |
|
I was looking into adding these tests such that we can get this merged. But at the moment I can't even get the dev requirements installed. Seems like phan is causing an impossible combination of dependencies. Any ideas on how to progress from here? |
Fixes open-telemetry/opentelemetry-php#1844