feat: support batch (getmany) in aiokafka instrumentation #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimastbk
commented
Feb 12, 2025
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
dimastbk
force-pushed
the
add-aiokafka-batch
branch
from
1347b0d to
76c8faa
Compare
|
@xrmx Hi. Could you take a look at this PR? |
emdneto
reviewed
Apr 10, 2025
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Apr 10, 2025
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Show resolved
Hide resolved
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Show resolved
Hide resolved
emdneto
reviewed
Apr 10, 2025
instrumentation/opentelemetry-instrumentation-aiokafka/tests/test_instrumentation.py
Show resolved
Hide resolved
xrmx
reviewed
Apr 10, 2025
dimastbk
force-pushed
the
add-aiokafka-batch
branch
from
72d396d to
c7704ef
Compare
emdneto
reviewed
Apr 15, 2025
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Apr 15, 2025
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Apr 15, 2025
| args, | ||
| kwargs, | ||
| ) | ||
| topic_span.add_link(record_span.get_span_context()) |
There was a problem hiding this comment.
This seems right to me, but would like to have double 👀 on this based on: https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#batch-receiving
dimastbk
force-pushed
the
add-aiokafka-batch
branch
from
92eed98 to
0467411
Compare
emdneto
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for reading batches in aiokafka (method
getmany).And some fixes:
partial fix #3087
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.