Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client address is set to server address in new semconv #3354

Merged
merged 8 commits into from
Mar 24, 2025
+22 −8
Merged

Fix client address is set to server address in new semconv #3354

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de843c6
Fix client address is set to server address
y-young Mar 11, 2025
79bd441
fix: asgi tests
y-young Mar 11, 2025
96c74c3
docs: update CHANGELOG
y-young Mar 11, 2025
4462f45
Merge branch 'main' into fix/client-address
y-young Mar 18, 2025
61ada6c
docs: update CHANGELOG
y-young Mar 18, 2025
dc434f7
refactor: only populate server address if missing
y-young Mar 18, 2025
d1a6c52
Merge branch 'main' into fix/client-address
emdneto Mar 21, 2025
3559c67
Merge branch 'main' into fix/client-address
lzchen Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: only populate server address if missing
@y-young
y-young committed Mar 18, 2025
commit dc434f73abca5b8dfbdeaf54f93a5125411104df
3 changes: 2 additions & 1 deletion opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
View file
Original file line number Diff line number Diff line change
@@ -354,7 +354,8 @@ def _set_http_host_server(result, host, sem_conv_opt_in_mode):
if _report_old(sem_conv_opt_in_mode):
set_string_attribute(result, SpanAttributes.HTTP_HOST, host)
if _report_new(sem_conv_opt_in_mode):
set_string_attribute(result, SERVER_ADDRESS, host)
if not result.get(SERVER_ADDRESS):
set_string_attribute(result, SERVER_ADDRESS, host)


# net.peer.ip -> net.sock.peer.addr