-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include more request configuration options into the span attributes for the Google GenAI SDK instrumentation #3374
Open
michaelsafyan
wants to merge
17
commits into
open-telemetry:main
Choose a base branch
from
michaelsafyan:google_genai_attribute_improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendly ping. Is it possible to get this reviewed? |
xrmx
reviewed
Mar 28, 2025
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Show resolved
Hide resolved
xrmx
approved these changes
Mar 28, 2025
I approved the PR because I think this would be helpful for you to move forward but would be nice to add a google genai specific section to the genai semantic conventions with these attributes you are exporting. Now it's really opaque and we don't have assertions on what we are actually exporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the comprehensiveness and uniformity of reporting span-level attributes for Google GenAI SDK operations.
This essentially dumps all of the configuration options into span attributes, with a vendor-specific prefix. The subset of request options that are defined in OTel Semantic Conventions are then renamed to match conventions.
In service of the above, this change also:
flatten_dict
util used to generate the span attributes.Type of change
How Has This Been Tested?
Added more integration tests, covering the relevant changes.
Does This PR Require a Core Repo Change?
Checklist: