botocore: handle tool calls with Amazon nova with Bedrock InvokeModel* APIs #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
aabmass
reviewed
Mar 27, 2025
...ation-botocore/tests/cassettes/test_invoke_model_no_content_tool_call[anthropic.claude].yaml
Outdated
Show resolved
Hide resolved
...ion-botocore/tests/cassettes/test_invoke_model_with_content_tool_call[anthropic.claude].yaml
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py
Show resolved
Hide resolved
xrmx
commented
Mar 28, 2025
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
aabmass
approved these changes
Mar 28, 2025
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py
Outdated
Show resolved
Hide resolved
Instead pass down a per-model object that implements the peculiar part. And fix recording of amazon.nova stream no content test.
xrmx
force-pushed
the
botocore-test-invokemodels-nova-tool-call.py
branch
from
1efd453 to
eae8841
Compare
xrmx
force-pushed
the
botocore-test-invokemodels-nova-tool-call.py
branch
from
eae8841 to
a216c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates current tool calls tests for InvokeModel* APIs and implementation to work also with amazon nova models on top of anthropic claude models.
Refs #3210
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.