[WIP] Chore: Drop support for Python 3.8 #3399
Draft
+3,951
−6,080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
github-actions
bot
assigned alizenhom, codeboten, codefromthecrypt, federicobond, gyliu513, jomcgi, karthikscale3, lmolkova, lzchen and NathanielRN
xrmx
reviewed
Apr 1, 2025
...us-remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/gogoproto/gogo_pb2.py
Outdated
Show resolved
Hide resolved
jomcgi
force-pushed
the
chore-4513/drop-py38-support
branch
from
26c0f26 to
71eb61e
Compare
jomcgi
commented
Apr 1, 2025
Comment on lines
+148
to
153
| # Starlette instrumentation is pinned to <0.15 from 2021-06-23 | ||
| # This creates a dependency conflict with instrumentation-genai/opentelemetry-instrumentation-google-genai | ||
| # TODO: remove exclusion when #3317 is resolved. | ||
| exclude = [ | ||
| "instrumentation-genai/opentelemetry-instrumentation-google-genai", | ||
| "instrumentation/opentelemetry-instrumentation-starlette", | ||
| ] |
There was a problem hiding this comment.
I think flipping this exclusion makes more sense given how outdated the starlette instrumentation is.
jomcgi
force-pushed
the
chore-4513/drop-py38-support
branch
2 times, most recently
from
fba15e8 to
e2360f6
Compare
jomcgi
commented
Apr 1, 2025
tox.ini
Outdated
Comment on lines
204
to
205
| # excluded from pypy3 due to missing wheel | ||
| pypy3.10-test-exporter-prometheus-remote-write |
There was a problem hiding this comment.
pypy3.9 is missing a wheel for cramjam causing this test to fail, if we feel it's necessary we could reopen milesgranger/cramjam#185
jomcgi
commented
Apr 1, 2025
| op.operation_name(): op | ||
| for op in globals().values() | ||
| if inspect.isclass(op) | ||
| and hasattr(op, "operation_name") |
There was a problem hiding this comment.
This condition was added here, lmdb.py and sns.py to resolve a test failure where inspect.isclass(op) returned true but issubclass(op, ... failed due to a value from globals not being recognized as a class.
jomcgi
force-pushed
the
chore-4513/drop-py38-support
branch
from
e2360f6 to
4f57fa3
Compare
dimastbk
reviewed
Apr 2, 2025
...pentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py
Outdated
Show resolved
Hide resolved
jomcgi
force-pushed
the
chore-4513/drop-py38-support
branch
from
4f57fa3 to
415fb0c
Compare
jomcgi
commented
Apr 4, 2025
| @@ -168,6 +171,7 @@ select = [ | |||
| "PLE", # pylint error | |||
| "Q", # flake8-quotes | |||
| "A", # flake8-builtins | |||
| "FA", # flake8-future-annotations | |||
There was a problem hiding this comment.
Added ruff lint rule that flags syntax that could be improved by future annotations
jomcgi
commented
Apr 4, 2025
| @@ -186,13 +190,15 @@ known-third-party = [ | |||
| "redis_opentracing", | |||
| "opencensus", | |||
| ] | |||
| required-imports = ["from __future__ import annotations"] | |||
There was a problem hiding this comment.
Added isort rule that makes future annotations a required/automatic import.
This can be removed when future annotations is deprecated in a future python upgrade.
jomcgi
force-pushed
the
chore-4513/drop-py38-support
branch
from
415fb0c to
5e91bf0
Compare
Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support will end @ 2024-04-07. Changes: * Removed all 3.8 references, updated basline refs to 3.9 * Updated python syntax with pyupgrade * Added isort rule to force future annotations import * Added ruff rule that enforces the use of future syntax
jomcgi
force-pushed
the
chore-4513/drop-py38-support
branch
from
5e91bf0 to
cbac8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support will end @ 2024-04-07.
Changes:
Fixes open-telemetry/opentelemetry-python#4513
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.