Add tornado WebSocketHandler instrumentation support #3498
+91
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
May 21, 2025
| response = func(*args, **kwargs) | ||
|
|
||
| _record_on_finish_metrics(server_histograms, handler) | ||
| try: |
There was a problem hiding this comment.
Not sure we should catch user code exception and change the code behavior, or if we do we should re-raise later.
There was a problem hiding this comment.
Its just a finally block to ensure that we finish the trace span and metrics, even if the user code raises an exception. It doesn't catch, so it shouldn't need to re-raise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tornado WebSocketHandler instrumentation support. Previously, the tornado instrumentation would improperly handle tracing and metrics that would end prematurely before the websocket connection was really closed (it would end when the HTTP connection was upgraded).
Fixes #2761
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added
TestTornadoInstrumentation.test_websockethandlertest which makes a websocket connection and ensures the traces are instrumented properly.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.