Improve asgi instrumentation example#3576
Merged
xrmx merged 5 commits intoopen-telemetry:mainfrom Jun 30, 2025
Merged
Conversation
xrmx
approved these changes
Jun 13, 2025
emdneto
approved these changes
Jun 13, 2025
Contributor
|
Need to fix |
devmonkey22
pushed a commit
to devmonkey22/opentelemetry-python-contrib
that referenced
this pull request
Aug 5, 2025
* Improve asgi instrumentation example * Fix indentation of asgi instrumentation example * Improve type hints of asgi instrumentation example * Ignore pylint too-many-lines --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
* Improve asgi instrumentation example * Fix indentation of asgi instrumentation example * Improve type hints of asgi instrumentation example * Ignore pylint too-many-lines --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's one instrumentation example inside
asgithat doesn't run. This PR fixes the example, so it runs.Type of change
How Has This Been Tested?
git clone https://github.com/open-telemetry/opentelemetry-python-contribgit clone https://github.com/open-telemetry/opentelemetry-pythoncd opentelemetry-python-contribpython3 -m venv otelvenvsource otelvenv/bin/activateasgispecific requirements:__init__.pyfile into different Python files and try to run them.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.