Skip to content

Conversation

@juandelacruz-calvo
Copy link

@juandelacruz-calvo juandelacruz-calvo commented Oct 17, 2025

Summary

This PR is a rebased version of PR #3384 that aims to update the OpenTelemetryClientInterceptor to support official gRPC client interceptor interfaces introduced in gRPC v1.8.0.

Changes

  • Remove external implementation of gRPC client interceptors (package grpcext)
  • Adapt the _client.py module based on the _aio_client.py module design
  • Remove the RpcInfo class from utilities.py
  • Update test_client_interceptor_trace_context_propagation tests
  • Update semantic conventions to use the new incubating attributes

Test plan

Tested locally, working with grpc client instrumentation, also working with PubSub consuming and publishing

Related Issues

🤖 Generated with Claude Code

@juandelacruz-calvo juandelacruz-calvo marked this pull request as ready for review October 17, 2025 14:32
@juandelacruz-calvo
Copy link
Author

juandelacruz-calvo commented Oct 20, 2025

This is really no longer needed to fix the issue for PubSub on GCP, since they released specific properties to instrument their software with OpenTelemetry: https://cloud.google.com/pubsub/docs/open-telemetry-tracing

But it helps to add manual intercepts to gRPC clients

@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants