Remove unnecessary dependencies #631
Conversation
ocelotl
requested review from
a team,
owais and
lzchen
and removed request for
a team
|
I think hhtpx can be removed as well. |
| @@ -41,7 +41,6 @@ install_requires = | |||
| opentelemetry-api ~= 1.3 | |||
| opentelemetry-semantic-conventions == 0.24b0 | |||
| opentelemetry-instrumentation == 0.24b0 | |||
| opentelemetry-instrumentation-botocore == 0.24b0 | |||
There was a problem hiding this comment.
Is this unnecessary or does botocore add some lower level spans that boto does not? Kind of like how flask and wsgi instrumentations work together?
There was a problem hiding this comment.
Hm, I'm not sure. Even if that is the case, do we want that to happen? It seems like a very problematic way of adding spans, just because some dependency is installed by an instrumentation package, imagine debugging that.
There was a problem hiding this comment.
I think it is reasonable to do. Otel Node does it quite a bit IIRC. Debugging would be the same whether it is installed automatically or manually but with automatic install, we ship a much better default UX IMO.
Sorry, where is |
|
@ocelotl |
If you take a look at that file, |
|
@owais |
|
Not a hard blocker for me but I'd like a better understanding of why boto has botocore as a dep. Does removing it mean users will have degraded experience if they just install boto instrumentation? |
I think this is something to address in a different issue/PR. Even if that is the case, it definitely needs more than just a dependency, that kind of behavionr needs to be documented somewhere, having spans just showing up when another package is installed is not user friendly either. |
|
Discussed in SIG, we are okay to merge this. |
Fixes #547